Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Load Chart drop-down menu: cosmetic improvements #144

Merged
merged 1 commit into from
May 18, 2017
Merged

Load Chart drop-down menu: cosmetic improvements #144

merged 1 commit into from
May 18, 2017

Conversation

jsperhac
Copy link
Contributor

Cosmetic improvements to the Metric Explorer Load Chart dialog.

Description

In Load Chart menu:

  • Display the dirty chart icon next to Last Modified Date for unsaved chart records. This replaces the text "Unsaved", matches the appearance of the Save drop-down, and preserves space in the Load Chart menu.
  • For charts with long names (>72 characters), display chart name in tooltip.

Motivation and Context

These changes were requested here: https://app.asana.com/0/14787510600562/75162375641137

Tests performed

These changes are strictly cosmetic. They have been tested by hand to ensure they behave as intended, and to ensure they don't disturb existing functionality. Existing, complete tests pass.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project as found in the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@jsperhac jsperhac added the enhancement Enhancement of the functionality of an existing feature label May 18, 2017
@jsperhac jsperhac added this to the v6.7.0 milestone May 18, 2017
plessbd
plessbd approved these changes May 18, 2017
View reviewed changes
Copy link
Contributor

@plessbd plessbd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might squash some of the commits, but LGTM

@plessbd
Copy link
Contributor

plessbd commented May 18, 2017

you could add some screenshots for before and after :)

jpwhite4
jpwhite4 approved these changes May 18, 2017
View reviewed changes
Copy link
Member

@jpwhite4 jpwhite4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash commits

@jsperhac jsperhac force-pushed the chart-dialog-list-improvements branch from 66b112e to a049d16 Compare May 18, 2017 19:13
@jsperhac
Copy link
Contributor Author

This enhancement includes the dirty chart icon seen here to flag unsaved records in the Load Chart menu:
new-way

...which replaces the "Unsaved" text that was used previously:
old-way

@jsperhac jsperhac merged commit 3ab5059 into ubccr:xdmod6.7 May 18, 2017
@tyearke tyearke mentioned this pull request Jun 6, 2017
Merged
@tyearke tyearke modified the milestones: v7.0.0, v6.7.0 Jun 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plessbd plessbd plessbd approved these changes

@jpwhite4 jpwhite4 jpwhite4 approved these changes

Assignees
No one assigned
Labels
enhancement Enhancement of the functionality of an existing feature
Projects
None yet
Milestone
v7.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@jsperhac @plessbd @jpwhite4 @tyearke